chore: Add react-native contract tets.#1149
Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/browser size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
The android-emulator-runner action executes scripts with /usr/bin/sh,
not bash. The {1..30} brace expansion is a bashism that causes a syntax
error in POSIX sh, which made the script fail immediately. Also adds a
30-minute job timeout to prevent runaway CI jobs.
The android-emulator-runner action runs each line of the script parameter as a separate /usr/bin/sh -c invocation. Multi-line constructs like for loops, if/fi blocks, and line continuations cannot work inline. Moved the entire script to run-ci-contract-tests.sh which is invoked as a single command.
The release build was spending ~7.5 min in CI building native code for 4 ABIs (arm64-v8a, armeabi-v7a, x86, x86_64) plus running lintVital. Since the emulator is x86_64, we only need that ABI. Switching to debug build also skips lintVital and R8/ProGuard (which weren't meaningful anyway as release was signed with debug keys). Expected savings: ~3-4 minutes (native builds for 3 unused ABIs + lint).
…de emulator Debug builds skip JS bundling and expect Metro dev server — the APK launched with no JavaScript code so it never connected to the WebSocket. Switched back to assembleRelease with x86_64-only ABI and skipping lintVital to keep the speed improvement. Moved log capture into the emulator runner script via a trap on EXIT. The previous "Print logs" step ran after the emulator was terminated, causing adb logcat to hang indefinitely.
| export default function App() { | ||
| const [connected, setConnected] = useState(false); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
This is slightly amusing.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
- Await flush() call in ClientEntity (joker23) - Pin sdk-test-harness download to v2.34.0 instead of latest (joker23)
SDK-1762
Note
Cursor Bugbot is generating a summary for commit 968a3f5. Configure here.